feat: sourcechain and asset attributes in link events #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs47
requested review from
cgorenflo,
haiyizxx and
fish-sammy
as code owners
fish-sammy
approved these changes
Jan 19, 2022
milapsheth
approved these changes
Jan 19, 2022
| @@ -68,9 +68,11 @@ func (s msgServer) Link(c context.Context, req *types.LinkRequest) (*types.LinkR | |||
| sdk.NewEvent( | |||
| types.EventTypeLink, | |||
| sdk.NewAttribute(sdk.AttributeKeyModule, types.ModuleName), | |||
| sdk.NewAttribute(types.AttributeKeySourceChain, exported.Axelarnet.Name), | |||
There was a problem hiding this comment.
Source chain could be another Cosmos chain though? We don't know at this point in time. But I guess we can add this for consistency.
There was a problem hiding this comment.
as of right now, in this module the source chain is always axelarnet:
if err := s.nexus.LinkAddresses(ctx,
nexus.CrossChainAddress{Chain: exported.Axelarnet, Address: depositAddress.String()},
recipient,
); err != nil {
return nil, fmt.Errorf("could not link addresses: %s", err.Error())
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Steps to Test
Expected Behaviour
Other Notes