feat(vald): new EVM config field #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs47
requested review from
cgorenflo,
haiyizxx and
fish-sammy
as code owners
fish-sammy
requested changes
Jan 25, 2022
x/evm/types/config.go
Outdated
| Name string `mapstructure:"name"` | ||
| RPCAddr string `mapstructure:"rpc_addr"` | ||
| WithBridge bool `mapstructure:"start-with-bridge"` | ||
| RPCModuleSupport bool `mapstructure:"rpc-module-support"` |
There was a problem hiding this comment.
This name is quite weird. It's basically saying if it's set to true, then do not try to detect whether or not it's beyond the standard ethereum jsonrpc. Maybe something like enable-rpc-detection.
fish-sammy
requested changes
Jan 25, 2022
Co-authored-by: Sammy Liu <sammy.liu@axelar.network>
Co-authored-by: Sammy Liu <sammy.liu@axelar.network>
fish-sammy
approved these changes
Jan 25, 2022
fish-sammy
reviewed
Jan 25, 2022
| Name string `mapstructure:"name"` | ||
| RPCAddr string `mapstructure:"rpc_addr"` | ||
| WithBridge bool `mapstructure:"start-with-bridge"` | ||
| EnableRPCDetection bool `mapstructure:"enable-rpc-detection"` |
There was a problem hiding this comment.
Just wanna confirm before you merge, does this mean that EnableRPCDetection is optional in the config.toml file and if one doesn't have it there it would default to true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon testing non-standard rpc methods (e.g., Moonbeam's
chain_getFinalizedHead), ganache returns error code -32000 (server error) instead of -32601 (method not found error). In order to be able to continue using ganache for local testing (as well as to account for other possible situations where we wouldn't want to support non-standard rpc functionality), this PR adds a new field in evm config params calledrpc-module-support, which allows vald to skip detecting non-standard rpc functionality.Todos
Steps to Test
Expected Behaviour
Other Notes