fix: allow unbonded validator to submit heartbeats #1256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a change in #1198 for missed blocks, we started returning an error for any validator whose signing info wasn't found. This includes any validator who's newly created but hasn't joined the active set yet. Also, any validator who gets unbonded will have missed blocks. Since we want to allow validators who are unbonding/unbonded to still sign for existing key IDs, we shouldn't exclude them from based on this illegibility.
This PR changes the missed blocks check to only be applicable for bonded validators.
Alternative approaches:
Todos
Steps to Test
Expected Behaviour
Other Notes