Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evm)!: sign key role for command batch #1258

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

fish-sammy
Copy link
Contributor

@fish-sammy fish-sammy commented Jan 26, 2022

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy changed the title feat/evm sign key role for commands feat(evm)!: sign key role for command batch Jan 26, 2022
@fish-sammy fish-sammy force-pushed the feat/evm-sign-key-role-for-commands branch from 2217f5a to ed8185f Compare January 26, 2022 19:39
@fish-sammy fish-sammy changed the base branch from main to feat/external-erc20-support January 26, 2022 19:39
@fish-sammy fish-sammy added the enhancement New feature or request label Jan 26, 2022
@fish-sammy fish-sammy force-pushed the feat/evm-sign-key-role-for-commands branch 2 times, most recently from 2585823 to c10d473 Compare January 27, 2022 16:39
@fish-sammy fish-sammy force-pushed the feat/evm-sign-key-role-for-commands branch from c10d473 to ccd74ca Compare January 27, 2022 16:44
@fish-sammy fish-sammy marked this pull request as ready for review January 27, 2022 16:48
Base automatically changed from feat/external-erc20-support to main January 27, 2022 16:52
@fish-sammy fish-sammy force-pushed the feat/evm-sign-key-role-for-commands branch 2 times, most recently from 8027caf to 55edf91 Compare January 27, 2022 17:33
@fish-sammy fish-sammy force-pushed the feat/evm-sign-key-role-for-commands branch from 55edf91 to 2cbb56d Compare January 27, 2022 17:36
Copy link
Contributor

@haiyizxx haiyizxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fish-sammy fish-sammy merged commit d531dd2 into main Jan 28, 2022
@fish-sammy fish-sammy deleted the feat/evm-sign-key-role-for-commands branch January 28, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants