fix(tss): add key ID validation upon heartbeat #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs47
requested review from
cgorenflo,
haiyizxx and
fish-sammy
as code owners
milapsheth
reviewed
Jan 27, 2022
milapsheth
approved these changes
Jan 27, 2022
Co-authored-by: Milap Sheth <milap@axelar.network>
|
The PR itself looks good but what was the reason that some validators sent heartbeat for keys that they didn't own? |
|
@sammy1991106 Just a misc validation observation on my part. Haven't seen any issues yet. |
fish-sammy
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1214
Todos
Steps to Test
Expected Behaviour
Other Notes