Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(migration): migrate states in axelarnet and nexus #1267

Merged
merged 8 commits into from
Feb 15, 2022
Merged

feat(migration): migrate states in axelarnet and nexus #1267

merged 8 commits into from
Feb 15, 2022

Conversation

haiyizxx
Copy link
Contributor

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy added the next release Required for the next release label Jan 31, 2022
@haiyizxx haiyizxx force-pushed the feat/register-asset-migration branch 3 times, most recently from 1501432 to 17362b2 Compare February 1, 2022 08:09
@haiyizxx haiyizxx force-pushed the feat/nexux-min-amount branch 2 times, most recently from c04742a to 678a12b Compare February 1, 2022 08:28
@haiyizxx haiyizxx force-pushed the feat/register-asset-migration branch 2 times, most recently from a1e53ea to 1793a3b Compare February 1, 2022 08:40
@haiyizxx haiyizxx force-pushed the feat/nexux-min-amount branch 2 times, most recently from 971a5c7 to 441e538 Compare February 1, 2022 18:28
@haiyizxx haiyizxx force-pushed the feat/register-asset-migration branch 2 times, most recently from fdb8cbe to 546b340 Compare February 1, 2022 19:17
@haiyizxx haiyizxx force-pushed the feat/register-asset-migration branch from 546b340 to 6e091ab Compare February 1, 2022 19:50
jcs47
jcs47 reviewed Feb 1, 2022
View reviewed changes
x/nexus/keeper/migrations.go Outdated Show resolved Hide resolved
@haiyizxx haiyizxx force-pushed the feat/register-asset-migration branch 3 times, most recently from b92a8cd to 932ebfe Compare February 2, 2022 06:53
@haiyizxx haiyizxx requested a review from jcs47 February 2, 2022 06:53
@haiyizxx haiyizxx marked this pull request as ready for review February 2, 2022 06:53
fish-sammy
fish-sammy reviewed Feb 2, 2022
View reviewed changes
x/axelarnet/module.go Outdated Show resolved Hide resolved
@haiyizxx haiyizxx force-pushed the feat/nexux-min-amount branch 2 times, most recently from e87b051 to 635db3d Compare February 2, 2022 07:01
@haiyizxx haiyizxx force-pushed the feat/register-asset-migration branch from 932ebfe to b2580d0 Compare February 2, 2022 07:03
@haiyizxx haiyizxx force-pushed the feat/nexux-min-amount branch 3 times, most recently from 42f8bee to 95e0793 Compare February 4, 2022 01:52
@haiyizxx haiyizxx force-pushed the feat/register-asset-migration branch 3 times, most recently from 4cee408 to 64a17a5 Compare February 4, 2022 03:35
@haiyizxx haiyizxx force-pushed the feat/nexux-min-amount branch 2 times, most recently from becdbd4 to 00528dc Compare February 10, 2022 17:26
@haiyizxx haiyizxx force-pushed the feat/register-asset-migration branch from 8feaad8 to 826d4cd Compare February 10, 2022 17:32
@haiyizxx haiyizxx force-pushed the feat/register-asset-migration branch 2 times, most recently from 13c8b2c to 49e905b Compare February 10, 2022 19:38
Base automatically changed from feat/nexux-min-amount to main February 10, 2022 19:40
@haiyizxx
refactor(nexus): handle minimum transfer amount
c511c8b
@haiyizxx
refactor: track native asset in nexus
f81e9ce 
- remove assets from CosmosChain struct
- make NativeAsset to list in Chain struct
@haiyizxx
update based on review
52c9d86 
- remove native assets and add is_native_asset flag
- changes base on suggestion
@haiyizxx
refactor: track native asset in nexus
edbed00 
- remove assets from CosmosChain struct
- make NativeAsset to list in Chain struct
@haiyizxx
update based on review
fb3b9e5 
- remove native assets and add is_native_asset flag
- changes base on suggestion
@haiyizxx
feat: migrate states in axelarnet and nexus
0931d9c
@haiyizxx
fix: cosmos chain struct
741ed27 
cosmos chains were not set properly, need rebuild before we clean other states
@haiyizxx haiyizxx force-pushed the feat/register-asset-migration branch from 49e905b to 741ed27 Compare February 10, 2022 19:44
fish-sammy
fish-sammy approved these changes Feb 15, 2022
View reviewed changes
x/nexus/types/expected_keepers.go
@@ -48,9 +49,15 @@ type StakingKeeper interface {
GetLastTotalPower(sdk.Context) sdk.Int
}

// AxelarnetKeeper procides functionality to the axelarnet module
// AxelarnetKeeper provides functionality to the axelarnet module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haiyizxx haiyizxx changed the title feat: migrate states in axelarnet and nexus feat(migration): migrate states in axelarnet and nexus Feb 15, 2022
@haiyizxx haiyizxx merged commit 809a617 into main Feb 15, 2022
@haiyizxx haiyizxx deleted the feat/register-asset-migration branch February 15, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fish-sammy fish-sammy fish-sammy approved these changes

@jcs47 jcs47 Awaiting requested review from jcs47

@cgorenflo cgorenflo Awaiting requested review from cgorenflo

Assignees
No one assigned
Labels
next release Required for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haiyizxx @fish-sammy @jcs47 @cgorenflo