feat(evm)!: prioritize executing burn commands #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fish-sammy
requested review from
cgorenflo,
haiyizxx and
jcs47
as code owners
Closed
fish-sammy
force-pushed
the
feat/cmd-queue-prefers-burn
branch
from
a0dc954
to
4b43068
Compare
fish-sammy
force-pushed
the
feat/cmd-queue-prefers-burn
branch
from
4b43068
to
d5379d0
Compare
cgorenflo
reviewed
Feb 4, 2022
| bz := make([]byte, 8) | ||
|
|
||
| switch command.Command { | ||
| case types.AxelarGatewayCommandBurnToken: |
There was a problem hiding this comment.
why is there no prefix at all in this case, shouldn't it be 0 or something?
There was a problem hiding this comment.
0 is just empty bytes and by doing nothing to bz, it is. @cgorenflo
cgorenflo
reviewed
Feb 4, 2022
Comment on lines
+1300
to
+1302
| if _, err := strconv.ParseInt(keyParticles[0], 10, 64); err != nil { | ||
| return fmt.Errorf("expected first key part of %s to be a block height", key) | ||
| } |
There was a problem hiding this comment.
is this not going to fail with a burn command in the queue?
There was a problem hiding this comment.
No it shouldn't. Burn commands' block heights at here are all 0's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Steps to Test
Expected Behaviour
Other Notes