build: remove ssh from build process since no more private dependencies #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fish-sammy
requested review from
cgorenflo,
haiyizxx and
jcs47
as code owners
fish-sammy
force-pushed
the
build/remove-ssh-from-build-process
branch
2 times, most recently
from
a5af6de
to
0bcd005
Compare
talalashraf
approved these changes
Feb 3, 2022
@talalashraf I like the cooler interface with buildkit haha, and also don't see any downside of keeping it. |
fish-sammy
force-pushed
the
build/remove-ssh-from-build-process
branch
from
0bcd005
to
f0cabbf
Compare
fish-sammy
force-pushed
the
build/remove-ssh-from-build-process
branch
from
f0cabbf
to
2cb676d
Compare
jcs47
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since axelar-core became open source, we no longer require any private dependency from our org and therefore ssh isn't needed anymore as part of the build process. Removing it would also allow Github actions to run in PRs from forks.
Todos
Steps to Test
Expected Behaviour
Other Notes