Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(axelarnet): cobra command to confirm deposits #1283

Merged
merged 2 commits into from
Feb 4, 2022
Merged

fix(axelarnet): cobra command to confirm deposits #1283

merged 2 commits into from
Feb 4, 2022

Conversation

jcs47
Copy link
Contributor

@jcs47 jcs47 commented Feb 4, 2022

Description

CLI command confirm-deposit at axelarnet did not match documention, thus still requiring 3 parameters

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@jcs47 jcs47 changed the title fix(axelarnet): CLI command to confirm deposits fix(axelarnet): cobra command to confirm deposits Feb 4, 2022
haiyizxx
haiyizxx approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@haiyizxx haiyizxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also updated in mine, urs get in first 😉

@jcs47 jcs47 merged commit 444c312 into main Feb 4, 2022
@jcs47 jcs47 deleted the fix/axelarnet_cli_confirm_deposit branch February 4, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiyizxx haiyizxx haiyizxx approved these changes

@milapsheth milapsheth milapsheth approved these changes

@cgorenflo cgorenflo Awaiting requested review from cgorenflo

@fish-sammy fish-sammy Awaiting requested review from fish-sammy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcs47 @haiyizxx @milapsheth