feat: batch vald broadcasts when traffic is high #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgorenflo
requested review from
haiyizxx,
jcs47 and
fish-sammy
as code owners
cgorenflo
commented
Feb 4, 2022
haiyizxx
reviewed
Feb 5, 2022
| func(err error) bool { | ||
| logger := b.logger.With("batch_size", len(msgs)) | ||
| i, ok := tryParseErrorMsgIndex(err) | ||
| if ok && len(msgs) > 1 { |
There was a problem hiding this comment.
any particular reason to check this first?
milapsheth
approved these changes
Feb 5, 2022
haiyizxx
approved these changes
Feb 5, 2022
Co-authored-by: Milap Sheth <milap@axelar.network>
cgorenflo
added a commit
that referenced
this pull request
Feb 5, 2022
(cherry picked from commit d19d32d)
haiyizxx
pushed a commit
that referenced
this pull request
Feb 5, 2022
cgorenflo
added a commit
that referenced
this pull request
Feb 5, 2022
cgorenflo
added a commit
that referenced
this pull request
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a new message queue from which broadcasts can be batched when the traffic becomes too high.