fix: unmarshal heartbeat responses #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgorenflo
requested review from
haiyizxx,
jcs47 and
fish-sammy
as code owners
fish-sammy
approved these changes
Feb 8, 2022
cmd/axelard/cmd/vald/tss/tss.go
Outdated
| var txMsg sdk.TxMsgData | ||
| var refundReply rewardtypes.RefundMsgResponse | ||
| var refundReply []rewardtypes.RefundMsgResponse |
There was a problem hiding this comment.
Suggested change
| var refundReply []rewardtypes.RefundMsgResponse | |
| var refundReplies []rewardtypes.RefundMsgResponse |
cgorenflo
force-pushed
the
fix_heartbeat
branch
from
1e9f45b
to
9540b37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The broadcaster can now send multiple messages per tx, and the heart beat code assumed there was always exactly one msg per tx. This fixes the heart beat code so any number of msgs can be sent, in particular multiple heart beats per tx.