feat(tss): heartbeat should not affect multisig signing #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fish-sammy
requested review from
cgorenflo,
haiyizxx and
jcs47
as code owners
fish-sammy
force-pushed
the
feat/heartbeat-should-not-affect-multisig-sign
branch
from
bb5892b
to
6b0aca5
Compare
jcs47
reviewed
Feb 9, 2022
Comment on lines
+164
to
+172
| func (v ValidatorIllegibility) FilterIllegibilityForTssSigning() ValidatorIllegibility { | ||
| mask := None | ||
|
|
||
| for _, illegibility := range GetValidatorIllegibilities() { | ||
| mask |= illegibility | ||
| } | ||
|
|
||
| return v & mask | ||
| } |
There was a problem hiding this comment.
It's more of a sanity thing, just to make sure v doesn't have any bit set to 1 beyond the defined range.
fish-sammy
deleted the
feat/heartbeat-should-not-affect-multisig-sign
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Steps to Test
Expected Behaviour
Other Notes