Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): update chain ID env var #1309

Merged
merged 2 commits into from
Feb 15, 2022
Merged

chore(docker): update chain ID env var #1309

merged 2 commits into from
Feb 15, 2022

Conversation

jcs47
Copy link
Contributor

@jcs47 jcs47 commented Feb 15, 2022

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

haiyizxx
haiyizxx approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@haiyizxx haiyizxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we pass this env when build docker image in the future instead of change it every time?

@jcs47 jcs47 merged commit f3d14eb into main Feb 15, 2022
@jcs47 jcs47 deleted the update/chainid branch February 15, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiyizxx haiyizxx haiyizxx approved these changes

@cgorenflo cgorenflo Awaiting requested review from cgorenflo

@fish-sammy fish-sammy Awaiting requested review from fish-sammy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcs47 @haiyizxx