feat(ante)!: allow refundable txs with more than a single message #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgorenflo
requested review from
jcs47,
haiyizxx and
fish-sammy
as code owners
haiyizxx
approved these changes
Feb 15, 2022
haiyizxx
reviewed
Feb 16, 2022
x/ante/check_refund.go
Outdated
| if !ok { | ||
| return ctx, sdkerrors.Wrap(sdkerrors.ErrTxDecode, "Tx must be a FeeTx") | ||
| } | ||
| if err := d.qualifyForRefund(ctx, msgs); err != nil { |
There was a problem hiding this comment.
It will prevent unbond validators to submit txs
milapsheth
reviewed
Feb 16, 2022
milapsheth
reviewed
Feb 16, 2022
|
One of the comments doesn't show up properly in the overview here. |
fish-sammy
reviewed
Feb 17, 2022
x/ante/check_refund.go
Outdated
| if validator == nil || !validator.IsBonded() { | ||
| return false | ||
| } | ||
| func (d CheckRefundFeeDecorator) qualifyForRefund(ctx sdk.Context, msgs []sdk.Msg) error { |
There was a problem hiding this comment.
So we are going to allow refund if and only if all msgs are RefundMsgRequest and contain registered inner msg, correct? If so, can you add a comment to this function so it becomes clearer?
There was a problem hiding this comment.
yes, that's correct
x/ante/check_refund.go
Outdated
| if validator == nil || !validator.IsBonded() { | ||
| return false | ||
| } | ||
| func (d CheckRefundFeeDecorator) qualifyForRefund(ctx sdk.Context, msgs []sdk.Msg) error { |
There was a problem hiding this comment.
Suggested change
| func (d CheckRefundFeeDecorator) qualifyForRefund(ctx sdk.Context, msgs []sdk.Msg) error { | |
| func (d CheckRefundFeeDecorator) validateRefundQualification(ctx sdk.Context, msgs []sdk.Msg) error { |
fish-sammy
approved these changes
Feb 18, 2022
milapsheth
reviewed
Feb 19, 2022
milapsheth
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.