fix(tss): remove keygen/sign metrics to avoid metrics bloat #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcs47
requested review from
cgorenflo,
haiyizxx and
fish-sammy
as code owners
fish-sammy
approved these changes
Feb 18, 2022
cgorenflo
reviewed
Feb 18, 2022
x/tss/abci.go
Outdated
Comment on lines
127
to
130
| // sign participation | ||
| telemetry.SetGaugeWithLabels([]string{types.ModuleName, "sign", "participation"}, | ||
| float32(len(k.GetSignParticipants(ctx, info.SigID))), []metrics.Label{telemetry.NewLabel("keyID", string(info.KeyID))}) | ||
|
|
There was a problem hiding this comment.
is this still going to bloat based on the key ID?
There was a problem hiding this comment.
Possibly, but keygen participation was also using keyID as a label, yet apparently wasn't causing any major issue. So I decided to preserve keyID for sign participation, and remove keyID from keygen participation. Nonetheless, if we find that sign participation metrics still result in bloat, we can completely remove them in an upcoming patch without having a consensus-breaking change (since those metrics are published via the end blocker and do nto modify the state).
There was a problem hiding this comment.
Since it seems unanimous that these should be removed, I did just that
added 2 commits
February 18, 2022 22:20
…r-core into abridged_tss_metrics
haiyizxx
approved these changes
Feb 18, 2022
jcs47
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1298
Todos
Steps to Test
Expected Behaviour
Other Notes