feat: adding matrix build #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalidax
requested review from
cgorenflo,
jcs47,
haiyizxx and
fish-sammy
as code owners
|
you tested this in another branch right ? can i see the outcome there ? |
erain9
previously requested changes
Feb 16, 2022
Nevermind - please ignore this. |
milapsheth
reviewed
Feb 16, 2022
milapsheth
reviewed
Feb 16, 2022
talalashraf
approved these changes
Feb 18, 2022
cgorenflo
approved these changes
Feb 18, 2022
milapsheth
reviewed
Feb 18, 2022
|
|
||
| - name: Unit test (check ledger support) | ||
| run: | | ||
| ./bin/axelard-* version --long |
There was a problem hiding this comment.
Suggested change
| ./bin/axelard-* version --long | |
| ./bin/axelard-"$OS"-"$ARCH"-"$SEMVER" version --long | grep "build_tags: ledger" |
Don't you want to grep for ledger in the build_tags and check if it's present? And just to be precise
kalidax
force-pushed
the
feat/build-matrix
branch
from
ab23065
to
0231561
Compare
talalashraf
pushed a commit
that referenced
this pull request
Feb 18, 2022
Co-authored-by: kalid <kalidax@axelar.network>
talalashraf
added a commit
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Steps to Test
Run the https://github.com/axelarnetwork/axelar-core/blob/feat/build-matrix/.github/workflows/build-docker-image-and-binaries.yaml . It is a job triggered manually.
select branch feat/build-matrix.
ideally create a S3 and an ECR for testing purpose.
Enter a semantic tag, you should not use an existing tag (VERY IMPORTANT), if you do so you will overwrite the existing binaries/images. You can check the latest version in the S3 axelar-releases.
Expected Behavior
The job will run on 5 os/architectures (3 Linux, 2 Darwin).
The build of container images will occur only on Ubuntu/amd64 that is the only job that will run all the steps
In the 4 remaining jobs, all container related steps will be skipped.
Other Notes
To ensure that Ledger is supported, you can check in the test step of each job see https://github.com/axelarnetwork/axelar-core/runs/5248523237?check_suite_focus=true#step:13:10 for example.
you should see "build_tags: ledger"