feat(evm): genesis import&export for events and confirmedEventQueue #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgorenflo
reviewed
Apr 4, 2022
utils/queuer.go
Outdated
Comment on lines
21
to
22
| ExportState() (state QueueState) | ||
| ImportState(state QueueState, validator ...func(QueueState) error) |
There was a problem hiding this comment.
I'd rather have this in a separate interface (if it's needed at all)
To me, exporting and importing state is not essential to the behaviour of a queue 😄
There was a problem hiding this comment.
I'll just remove them from the interface.
utils/queuer.go
Outdated
| } | ||
|
|
||
| // ImportState imports the given queue state into the kv store | ||
| func (q GeneralKVQueue) ImportState(state QueueState, validator ...func(QueueState) error) { |
There was a problem hiding this comment.
Suggested change
| func (q GeneralKVQueue) ImportState(state QueueState, validator ...func(QueueState) error) { | |
| func (q GeneralKVQueue) ImportState(state QueueState, validate ...func(QueueState) error) { |
There was a problem hiding this comment.
on a related note, we do you pass in the state and the validate function instead of passing in validated state?
fish-sammy
force-pushed
the
feat/genesis-export-import-gateway-tx
branch
from
d585aba
to
88a130e
Compare
cgorenflo
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Steps to Test
Expected Behaviour
Other Notes