Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change vald default config #1728

Merged
merged 2 commits into from
Sep 5, 2022
Merged

fix: change vald default config #1728

merged 2 commits into from
Sep 5, 2022

Conversation

milapsheth
Copy link
Member

Description

  • Decrease vald retries, to reduce retry loops
  • Increase timeout period for tx to be committed, to reduce timeout errors
  • Decrease old block window that vald will process, to decrease submission for expired signing etc.

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@milapsheth milapsheth added the next release Required for the next release label Sep 5, 2022
@milapsheth milapsheth merged commit 18e2d8c into main Sep 5, 2022
@milapsheth milapsheth deleted the vald-config branch September 5, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiyizxx haiyizxx haiyizxx approved these changes

@fish-sammy fish-sammy fish-sammy approved these changes

@cgorenflo cgorenflo Awaiting requested review from cgorenflo

@jcs47 jcs47 Awaiting requested review from jcs47

Assignees
No one assigned
Labels
next release Required for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@milapsheth @fish-sammy @haiyizxx