Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8-31-2022 ceremony comments/fixes #47

Closed
canhtrinh opened this issue Aug 31, 2022 · 0 comments
Closed

8-31-2022 ceremony comments/fixes #47

canhtrinh opened this issue Aug 31, 2022 · 0 comments

Comments

@canhtrinh
Copy link
Collaborator

canhtrinh commented Aug 31, 2022

today's ceremony comments:
[x] - BUG: edge case where you have a certain srcChain/destChain/asset combination AND THEN SWITCH to another chain combination where the asset isn't supported. black screen of death. to reproduce, go from Osmosis src chain, with WBNB asset selected. change Osmosis to something else. get a black screen. The error is coming because bnb is not available between moonbeam and axelar (on mainnet). also, this leads to an error page: https://canh-testing.vercel.app/?asset_denom=wbnb-wei&destination=axelar&source=moonbeam. fixed by #48
add Connect button on src chain next to "Available Balance" if src chain wallet is not connected yet.
[x] - “top flow” doesn’t close when i select. fixed in #49
[x] - max transfer doesn’t show up for some chains. (0) for others. ==> so, my understanding is that we only show the max when you select an EVM chain as a destination chain where the max is actually set (i.e. not zero). so that's the treatment there. but displaying zero is an issue that is fixed here: 2de2637
[x] - text change: “OR USE FROM SATELLITE” -> or send via your wallet. => addressed here: 726a79a4d8e5ba900ad45c0f7df9406caff250b7
[x] - right-align logo and "powered by axelar": addressed here: 726a79a4d8e5ba900ad45c0f7df9406caff250b7
image
[x] - cancel transfer while it’s in progress? users will think they can revert. should hide or change the language to something like “refresh or make another transfer”. replace X something related => addressed here: 726a79a4d8e5ba900ad45c0f7df9406caff250b7
[x] - switch to a black browser icon? hard to see
image => addressed here: 726a79a4d8e5ba900ad45c0f7df9406caff250b7
[x] - “execution of asset transfer to” -> “your destination address” => addressed here: 726a79a4d8e5ba900ad45c0f7df9406caff250b7
image
[x] - When loading Satellite, the Maximum Transfer Amount query takes a while but as a result the UI doesn't keep space for it and then adds it later which causes the UI to resize. Try a few refreshes when looking at the field location to see what I mean => (kind of) addressed here (with a hack): 5e909ff
[x] - Rejecting Keplr deposit pop-up keeps Satellite in waiting for deposit status (for e.g. maybe the user wants to change the amount / wallet address and retry) => they're not actually prevented from doing that if they hit cancel...
[x] - Link to destination chain transaction hash block explorer - nevermind, no need to do this since those links are available in axelarscan anyway
[x] - On step 2, show the min/max transfer amounts
[x] - Should show relayer gas fee after transfer initiation too (since we allow the user to change the amount there)
[x] - On transfer completion, the completed/success message should be front and center, with a link to axelarscan I think, instead of the addresses and tx hash (which is more useful if the transfer doesn’t complete).

[] - a few assets and chains are missing their image / using a default in the dropdowns
[] - revisit estimated wait times now that they're shorter
[] - Pressing Autofill with Keplr when it’s not available (say on Firefox) moves the UI weirdly and doesn’t show an error
[] - TODO: Try some parallel transfers. Are we making use of more info from the deposit confirmation events to create the topic now?
[] - Cosmostation support (for later)

From earlier:
[] - “Waiting for transaction confirmation” => include number of confirmations (if possible) while waiting

This was referenced Aug 31, 2022
canhtrinh added a commit that referenced this issue Aug 31, 2022
* chore: potential bugfix for first issue in #47

* fix

Co-authored-by: vladwulf <agaev.vladimir@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant