Integrate Third-Party API for Weather Data #1
Conversation
| use Symfony\Component\DependencyInjection\ContainerInterface; | ||
|
|
||
| /** | ||
| * Provides a 'Hello' Block. |
There was a problem hiding this comment.
@axelerant-hardik Please provide proper comments for the class or plugin
There was a problem hiding this comment.
Just some copy and paste stuff here. I will correct this.
| return []; | ||
| } | ||
|
|
||
| // Get location details from session. |
There was a problem hiding this comment.
@axelerant-hardik Why does the comment say "Get location details from the session"? I think the city will be stored in the block configuration, not the session.
There was a problem hiding this comment.
Yes, you're correct. I will update the comment.
|
|
||
| // Endpoint that should be hit. | ||
| $request_url = $weather_settings->get('base_url') . '/current.json'; | ||
| // Make a HTTP GET request to the endpoint. | ||
| try { | ||
| $request = $this->httpClient->request('GET', $request_url, [ | ||
| 'query' => [ | ||
| 'key' => $weather_settings->get('api_key'), | ||
| 'q' => $city, | ||
| 'units' => 'metric', | ||
| ], | ||
| ]); | ||
|
|
||
| // Parse the response. | ||
| $response = Json::decode($request->getBody()); | ||
| $weather_data = []; | ||
| $weather_data['location'] = $response['location']['name'] . ', ' . $response['location']['region'] . ', ' . $response['location']['country']; | ||
| $weather_data['temperature'] = $response['current']['temp_c']; | ||
| $weather_data['feels_like'] = $response['current']['feelslike_c']; | ||
| $weather_data['weather_condition_icon'] = $response['current']['condition']['icon']; | ||
| $weather_data['weather_condition_text'] = $response['current']['condition']['text']; | ||
| $weather_data['wind'] = $response['current']['wind_kph']; | ||
| $weather_data['precipitation'] = $response['current']['precip_mm']; | ||
|
|
There was a problem hiding this comment.
@axelerant-hardik I think it would be better to add this business logic inside the service file. Hence we can call service anywhere if it is required.
There was a problem hiding this comment.
@iyyappan-axelerant I was thinking of having a service file initially then dropped the idea considering it would be used only in this location. But, yes from a wider POV, it makes sense to have this as a service. I can add a service file!
Thank you for reviewing the PR and providing feedback!
| $city = $this->configuration['city']; | ||
| if (!$city) { | ||
| $city_not_found_message = $this->t('No city entered. Please enter a city to see the weather details'); | ||
| return [ | ||
| '#markup' => '<div class="weather--error">' . $city_not_found_message . '</div>', | ||
| ]; | ||
| } |
There was a problem hiding this comment.
@axelerant-hardik can you help in which situation users will see this message? Asking this as I see this field as required.
$form['city'] = [
'#type' => 'textfield',
'#title' => $this->t('City'),
'#description' => $this->t('Please enter the city to show weather details. Eg: Mumbai, India'),
'#default_value' => $this->configuration['city'],
'#required' => TRUE,
];
|
Closing this PR on behalf of #6. |
No description provided.