Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added twig code standard check using twigcs #4

Merged
merged 2 commits into from May 27, 2020
Merged

Added twig code standard check using twigcs #4

merged 2 commits into from May 27, 2020

Conversation

woredeyonas
Copy link
Contributor

I've added twigcs in the default grumphp.yml.dist

skippednote
skippednote reviewed May 26, 2020
View reviewed changes
grumphp.yml.dist Outdated Show resolved Hide resolved
@hussainweb
Copy link
Member

I'm thinking we should also add friendsoftwig/twigcs to composer.json's suggests list. We don't want to add it to require in case somebody can't use it for any reason.

@hussainweb
Copy link
Member

Closes #3

@hussainweb hussainweb changed the title Added twig code standard check Added twig code standard check using twigcs May 26, 2020
skippednote
skippednote approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@skippednote skippednote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this as default.

@hussainweb hussainweb merged commit 4827b44 into axelerant:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussainweb hussainweb hussainweb left review comments

@skippednote skippednote skippednote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woredeyonas @hussainweb @skippednote