Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links are not working in the common areas of concern in web projects index page #39

Closed
Yemaneberhan-Lemma opened this issue May 16, 2023 · 2 comments · Fixed by #42
Closed

Links are not working in the common areas of concern in web projects index page #39

Yemaneberhan-Lemma opened this issue May 16, 2023 · 2 comments · Fixed by #42

Comments

@Yemaneberhan-Lemma
Copy link
Contributor

Links in the common areas of concern in web projects index page are not working.
@Yemaneberhan-Lemma Yemaneberhan-Lemma changed the title Links are in the common areas of concern in web projects index page Links are not working in the common areas of concern in web projects index page May 16, 2023
hussainweb added a commit that referenced this issue May 17, 2023
@hussainweb
fix: set a different baseUrl for environments. Fixes #39
ea0d7be
@hussainweb hussainweb mentioned this issue May 17, 2023
Merged
hussainweb added a commit that referenced this issue May 17, 2023
@hussainweb
Merge pull request #42 from axelerant/fix-urls
740b5fc 
fix: set a different baseUrl for environments. Fixes #39
@hussainweb hussainweb reopened this May 17, 2023
@hussainweb
Copy link
Member

The problem is elsewhere. I didn't really need #42 but it doesn't hurt either.

@hussainweb
Copy link
Member

@Yemaneberhan-Lemma, please see the fix in 85b101e. We should use relref whenever we need to output links. See https://gohugo.io/functions/relref/

hussainweb added a commit that referenced this issue May 17, 2023
@hussainweb
Revert "fix: set a different baseUrl for environments. Fixes #39"
eaa83aa
@hussainweb hussainweb mentioned this issue May 17, 2023
Merged
hussainweb added a commit that referenced this issue May 17, 2023
@hussainweb
Merge pull request #43 from axelerant/revert-42-fix-urls
448bd1b 
Revert "fix: set a different baseUrl for environments. Fixes #39"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set a different baseUrl for environments. Fixes #39 axelerant/engg-handbook
2 participants
@hussainweb @Yemaneberhan-Lemma