Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing the Code Review Pyramid reference #92

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Introducing the Code Review Pyramid reference #92

merged 1 commit into from
Aug 21, 2023

Conversation

axelabhay
Copy link
Contributor

@axelabhay axelabhay commented Aug 21, 2023 •
edited by hussainweb

@netlify
Copy link

netlify bot commented Aug 21, 2023 •
edited

✅ Deploy Preview for axelerant-engg-handbook ready!

Name Link
🔨 Latest commit 60e8142
🔍 Latest deploy log https://app.netlify.com/sites/axelerant-engg-handbook/deploys/64e3702322d7e00008a0a275
😎 Deploy Preview https://deploy-preview-92--axelerant-engg-handbook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hussainweb
hussainweb approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@hussainweb hussainweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good and we should also have a dedicated page about code reviews.

@hussainweb hussainweb merged commit a002ee9 into axelerant:main Aug 21, 2023
7 checks passed
@hussainweb hussainweb mentioned this pull request Aug 21, 2023
Open
@axelabhay
Copy link
Contributor Author

This is good and we should also have a dedicated page about code reviews.

Noted (https://docs.google.com/document/d/1ax_c4HRIFBsO4u3lzSr_UJS-L4X8MItI_8DFiJ7pmvs/edit?disco=AAAA3QRBG4Y).

@Yemaneberhan-Lemma
Copy link
Contributor

https://axelerant.github.io/engg-handbook/docs/how-we-work/git/pull-request/#:~:text=PR%20Reviews%20and%20Comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussainweb hussainweb hussainweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@axelabhay @Yemaneberhan-Lemma @hussainweb