New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLite index on index columns? #210
Comments
I think we'd be open to a PR for this, as I don't see why we shouldn't have a SQLite index on the column (and possibly others) unless there is potential for file size problems or lack of implementation support for indexes (I don't know). I think we should probably add indexes optionally via config. |
- dist: Remove old Node minified files - Enhancement: Add `useSQLiteIndexes` option to add (and drop) SQLite indexes where utilized (indexeddbshim#210) - Fix: Ensure prevunique cursor presorts key in ascending order so will skip over later keys - Docs (README): Add link to IDB spec - Testing (QUnit, Fake, Mock, W3C Old, Mocha, W3C): Utilize `useSQLiteIndexes` config in tests (more complex) - Testing (Qunit): Remove references to old Node minified files
- dist: Remove old Node minified files - Enhancement: Add `useSQLiteIndexes` option to add (and drop) SQLite indexes where utilized (indexeddbshim#210) - Fix: Ensure prevunique cursor presorts key in ascending order so will skip over later keys - Docs (README): Add link to IDB spec - Testing (QUnit, Fake, Mock, W3C Old, Mocha, W3C): Utilize `useSQLiteIndexes` config in tests (more complex) - Testing (Qunit): Remove references to old Node minified files
- dist: Remove old Node minified files - Enhancement: Add `useSQLiteIndexes` option to add (and drop) SQLite indexes where utilized (indexeddbshim#210) - Fix: Ensure prevunique cursor presorts key in ascending order so will skip over later keys - Docs (README): Add link to IDB spec - Testing (QUnit, Fake, Mock, W3C Old, Mocha, W3C): Utilize `useSQLiteIndexes` config in tests (more complex) - Testing (Qunit): Remove references to old Node minified files - Testing/Grunt: Switch to non-minified babel-polyfill
indexes where utilized (indexeddbshim#210) - Fix: Ensure `prevunique` cursor presorts key in ascending order so will skip over later keys - dist: Remove old Node minified files - Docs (README): Add link to IDB spec - Testing (QUnit, Fake, Mock, W3C Old, Mocha, W3C): Utilize `useSQLiteIndexes` config in tests (more complex) - Testing (Qunit): Remove references to old Node minified files - Testing/Grunt: Switch to non-minified babel-polyfill
This is now implemented in
Btw, the reason for the special encoding of keys also relates to IndexedDB sorting requirements. Thanks for the report! |
This is more of an implementation question, not a bug.
This project has a very interesting implementation for IDB indexes on top of SQLite.
I see indexes are created by creating a new BLOB column in the table, and using a specific encoding to allow correct sorting/filtering.
This is done here:
https://github.com/axemclion/IndexedDBShim/blob/master/src/IDBIndex.js#L96
However, I don't see that a SQLite index is ever created on that column. It seems like the entire point of the special encoding of keys would be allowing a SQLite index to be used on that. Am I just missing it? Or is there a reason that no index is added?
The text was updated successfully, but these errors were encountered: