Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging bug with multiEntry cursor not returning all matches #200

Merged
merged 2 commits into from
May 27, 2015

Conversation

pixel9
Copy link
Contributor

@pixel9 pixel9 commented May 12, 2015

Results are limited to matches found within the first 100 rows because of the paging logic. Removed paging logic to do a full table scan when doing a multiEntry cursor prefetch.

There doesn't seem to be a simple way to avoid a full table scan for multiEntry index matches anyhow.

Yusuke Morita added 2 commits May 12, 2015 13:39
There's no way around doing a full table scan for cursors against multi entry indexes.
@JamesMessinger
Copy link
Collaborator

Sorry for the delay. I've been away on vacation. I'm looking at this now. Creating some unit tests first to demonstrate the problem, then I'll merge your fix.

JamesMessinger added a commit that referenced this pull request May 27, 2015
Paging bug with multiEntry cursor not returning all matches
@JamesMessinger JamesMessinger merged commit 4de03ea into indexeddbshim:master May 27, 2015
JamesMessinger added a commit that referenced this pull request May 28, 2015
@pixel9
Copy link
Contributor Author

pixel9 commented May 28, 2015

No worries! Thanks for merging this. It's always a nice feeling being on the latest official version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants