fix: wrong returned gas used and handler crash in debug APIs #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using debug APIs, system transaction goes through ApplyMessage which currently accounts for instrinsicGas and refund while normal flow through Finalize/FinalizeAndAssemble does not. This commit adds an IsSystemTransaction to evm's config, when system transaction goes through ApplyMessage, turn on this flag so that gasUsed does not account for intrinsicGas and refund.
DNK90
approved these changes
May 17, 2023
FlatCallTracer had a crasher when it was passed `onlyTopCall: true` as config. This PR ignores config fields inherited from the normal call tracer.
andicrypt
pushed a commit
to andicrypt/ronin
that referenced
this pull request
Nov 1, 2023
…inity#276) * fix: wrong returned gas used of system transaction in debug APIs When using debug APIs, system transaction goes through ApplyMessage which currently accounts for instrinsicGas and refund while normal flow through Finalize/FinalizeAndAssemble does not. This commit adds an IsSystemTransaction to evm's config, when system transaction goes through ApplyMessage, turn on this flag so that gasUsed does not account for intrinsicGas and refund. * eth/tracers: fix flatCallTracer crasher (#27304) FlatCallTracer had a crasher when it was passed `onlyTopCall: true` as config. This PR ignores config fields inherited from the normal call tracer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using debug APIs, system transaction goes through ApplyMessage which
currently accounts for instrinsicGas and refund while normal flow through
Finalize/FinalizeAndAssemble does not. This commit adds an IsSystemTransaction to
evm's config, when system transaction goes through ApplyMessage, turn on this
flag so that gasUsed does not account for intrinsicGas and refund.
FlatCallTracer had a crasher when it was passed
onlyTopCall: trueas config.This PR ignores config fields inherited from the normal call tracer.