fix(chat): filter named entity death messages

axieum · Aug 28, 2021 · b916d80 · b916d80
1 parent 8b0f723
commit b916d80
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.../main/java/me/axieum/mcmod/minecord/impl/chat/callback/minecraft/EntityDeathCallback.java b/.../main/java/me/axieum/mcmod/minecord/impl/chat/callback/minecraft/EntityDeathCallback.java
@@ -16,6 +16,9 @@ public class EntityDeathCallback implements EntityDeathEvents.Entity
     @Override
     public void onEntityDeath(LivingEntity entity, DamageSource source)
     {
+        // Only listen for named animal/monsters (with a name tag)
+        if (!entity.hasCustomName()) return;
+
         Minecord.getInstance().getJDA().ifPresent(jda -> {
             final String entityName = entity.getDisplayName().getString();
 

diff --git a/minecord-chat/src/main/java/me/axieum/mcmod/minecord/impl/chat/config/ChatConfig.java b/minecord-chat/src/main/java/me/axieum/mcmod/minecord/impl/chat/config/ChatConfig.java
@@ -45,7 +45,7 @@ public static class Discord
             @Comment("""
                 A player had died
                 Usages: ${username}, ${player}, ${cause}, ${world}, ${x}, ${y}, ${z}, ${score} and ${exp}""")
-            public String death = "**${player}** ${cause}!\n:skull: _${world} | ${x}, ${y}, ${z}_";
+            public String death = "**${player}** ${cause}! :skull:\n_${world} | ${x}, ${y}, ${z}_";
 
             @Comment("""
                 A named animal/monster (with name tag) had died