Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RefCell inside Arc #8

Closed
jonathanpwang opened this issue Oct 21, 2023 · 1 comment
Closed

RefCell inside Arc #8

jonathanpwang opened this issue Oct 21, 2023 · 1 comment

Comments

@jonathanpwang
Copy link
Contributor

https://github.com/axiom-crypto/halo2-wasm/blob/b02413ca50c1914a5b39f0768ebd3d98a15cb84c/src/lib.rs#L73

Usually one uses either Rc<RefCell> if it is not intended to be thread-safe, or Arc<Mutex> if it is supposed to be thread-safe (the Mutex locks until the given thread gets access to the object).

What is the intended use case here?
@rpalakkal
Copy link
Contributor

Not intended to be thread-safe -- changed to Rc<RefCell> in a733ab8. Thanks.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rpalakkal @jonathanpwang