Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EnableCloudTrail Parameter #60

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add EnableCloudTrail Parameter #60

merged 1 commit into from
Apr 9, 2024

Conversation

a-khaledf
Copy link
Collaborator

Description

For the subscriber lambda to be notified with each new Cloudwatch logGroup Created, it needs:

  • CloudTrail to be enabled to send notification to eventbridge.
  • AWS event rule to execute the subscriber lambda with each cloudwatch CreateLogGroup event published.

This PR add the option to skip enabling CloudTrail, if CloudTrail is already enabled.

@a-khaledf a-khaledf requested a review from schehata April 9, 2024 14:57
@schehata
Copy link
Contributor

schehata commented Apr 9, 2024

Fixes #52

schehata
schehata approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@schehata schehata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schehata schehata merged commit c1c3ba9 into main Apr 9, 2024
2 checks passed
@schehata schehata deleted the feat/make-cloudtrail-optional branch April 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schehata schehata schehata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a-khaledf @schehata