Add HN example, add try_ingest_stream and fix client construction, add tracing #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahlo
force-pushed
the
arne/hn-example
branch
6 times, most recently
from
576d18a
to
f2527f7
Compare
bahlo
changed the title
bahlo
force-pushed
the
arne/hn-example
branch
2 times, most recently
from
5ee0b3a
to
b1bbf0a
Compare
bahlo
force-pushed
the
arne/hn-example
branch
4 times, most recently
from
8805ae2
to
2736e59
Compare
Merged
schehata
approved these changes
Aug 8, 2022
If an env var was defined, but empty, env::var would return Some("").
This commit handles empty env vars the same as non-existent.
This method is useful if you have a stream of `Result`s.
It only works for personal tokens and the name is confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a HN example and includes a few fixes and additions that were found while writing the example:
Results thetry_ingest_streammethod is useful