fix: prevent heading lines overlap with navbar in desktop mode #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the margin-top property for the heading lines within the section#hero div.content to ensure proper spacing and prevent overlap with the navigation bar in desktop mode.
ahmed0saber
reviewed
Dec 17, 2023
There was a problem hiding this comment.
Hello @Firdous708 ,
I faced the same issue and came here to add it, but found your solution, your solution works well on your device, but by increasing the width of screen, we will face the same issue again.
To prevent this issue from its root, we need to use position sticky instead of fixed, and top 0 is required also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Adjusted the
margin-topproperty for the heading lines withinsection#hero div.contentto ensure proper spacing. This resolves the issue of overlap with the navigation bar in desktop mode.Fixes #147
Preview
Here's how the page looks after the fix:
Axios.1.mp4