Fixing interpretation of no_proxy by checking correct hostname

as suggested by #434
axios · Jul 20, 2017 · 24ecb51 · 24ecb51
1 parent ed47ef8
commit 24ecb51
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/adapters/http.js b/lib/adapters/http.js
@@ -116,7 +116,7 @@ module.exports = function httpAdapter(config) {
             password: proxyUrlAuth[1]
           };
         }
-        if (isANoProxyHost(proxy.host)) {
+        if (isANoProxyHost(parsed.hostname)) {
           proxy = undefined;
         }
       }

diff --git a/test/unit/adapters/http.js b/test/unit/adapters/http.js
@@ -382,7 +382,7 @@ module.exports = {
         });
       }).listen(4000, function() {
         // set the env variable
-        process.env.http_proxy = 'http://localhost:4000/';
+        process.env.http_proxy = 'http://127.0.0.1:4000/';
         process.env.no_proxy = 'localhost';
 
         axios.get('http://localhost:4444/').then(function(res) {