Adding a way to disable all proxy processing (#691) again

axios · Aug 20, 2017 · 44967bf · 44967bf
1 parent 94b8c55
commit 44967bf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/adapters/http.proxy.js b/lib/adapters/http.proxy.js
@@ -20,7 +20,7 @@ var getProxyForUrl = require('proxy-from-env').getProxyForUrl;
  */
 module.exports = function getProxy(config) {
   var proxy = config.proxy;
-  if (!proxy) {
+  if (!proxy && proxy !== false) {
     var envProxy = getProxyForUrl(config.url);
     if (envProxy) {
       var parsedProxyUrl = url.parse(envProxy);
@@ -38,5 +38,5 @@ module.exports = function getProxy(config) {
       }
     }
   }
-  return proxy;
+  return proxy || undefined;
 };
diff --git a/test/unit/adapters/proxy.js b/test/unit/adapters/proxy.js
@@ -91,6 +91,13 @@ module.exports = {
     test.done();
   },
 
+  proxyUnsetFromConfigOverridesProxyFromEnv: function(test) {
+    process.env.http_proxy = 'http://bob:secret@corpproxy.com:77/';
+    var proxy = getProxy(config({proxy: false}));
+    test.equal(proxy, undefined);
+    test.done();
+  },
+
   readProxyFromCorrectEnv: function(test) {
     process.env.https_proxy = 'http://corpproxy.com/';
     test.equal(getProxy(config()), undefined);