Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript definition for AxiosError should include request? #1014

Closed
mmarvick opened this issue Jul 25, 2017 · 3 comments
Closed

Typescript definition for AxiosError should include request? #1014

mmarvick opened this issue Jul 25, 2017 · 3 comments

Comments

@mmarvick
Copy link
Contributor

#### Summary

The current Typescript definition for AxiosError has all of the fields that can be on an error except for the optional request? param.

See this code where these errors are created.

#### Context

  • axios version: v0.16.2
  • Environment: React Native 0.42.0 (this is irrelevant)
mmarvick added a commit to mmarvick/axios that referenced this issue Jul 25, 2017
@mmarvick
Update Typescript typing for AxiosError to include request? param
0012154 
I made the type `any`. It looks like the actual type is generally `XMLHttpRequest`, but I'm not sure that that's true in all cases. Would be happy to change that if advised otherwise.

ref axios#1014
@mmarvick mmarvick mentioned this issue Jul 25, 2017
Merged
@rubennorte
Copy link
Member

Merged. Thanks for your contribution.

@rsimp
Copy link

rsimp commented Oct 9, 2017

@rubennorte I don't believe you published this correctly. I can see the updated index.d.ts on github, but npm is serving up an old version still.

@rsimp rsimp mentioned this issue Oct 9, 2017
Closed
@mmarvick
Copy link
Contributor Author

mmarvick commented Oct 9, 2017

A new version hasn't been released yet: https://github.com/axios/axios/releases

@jmmk jmmk mentioned this issue Oct 15, 2017
Merged
@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rubennorte @rsimp @mmarvick