-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buffer deprecation warning #1555
Comments
JustinBeckwith
pushed a commit
that referenced
this issue
Jul 5, 2018
This has been fixed and merged! |
This was referenced Aug 13, 2019
This was referenced Aug 29, 2019
This was referenced Sep 22, 2019
This was referenced Oct 16, 2019
This was referenced Oct 26, 2019
This was referenced Jan 9, 2020
This was referenced Mar 25, 2020
This was referenced Apr 1, 2020
This was referenced Apr 9, 2020
This was referenced Apr 16, 2020
Why is this closed? |
This was referenced Apr 25, 2020
Hi it seems that it has been merged, if you think there is still an issue please open a new issue this one seems pretty busy. |
This was referenced Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Summary
I have looked but I didn't manage to find this issue, it's probably a known issue but
Buffer()
is deprecated in the latest Node version:https://github.com/axios/axios/blob/master/lib/adapters/http.js#L42
https://github.com/axios/axios/blob/master/lib/adapters/http.js#L44
https://github.com/axios/axios/blob/master/lib/adapters/http.js#L127
Node produces the warning
[DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Is this as simple as changing the 2 lines I can see to
Buffer.from(...)
instead ofnew Buffer(...)
- if so, I'm happy to raise a PR if it's helpful.Context
The text was updated successfully, but these errors were encountered: