cancelling cancelToken on request that is already finished gives error

[vissermc]

there should be an easy mechanism to have 'overwrite' a request with a new one. Currently this is not possible. Also, it's not clear whether a cancelToken can be 'recycled', or whether a new one should be generated on every request

if (cancelToken) cancelToken.cancel();
cancelToken = axios.CancelToken.source();
axios.get(...

[nickuraltsev]

• What error do you get? Also, could you please provide a code snippet that reproduces the issue?
• I'm not sure I understand what you mean by "overwriting" requests.
• You should use different tokens for different requests unless you need to be able to cancel multiple requests as a group.

[vissermc]

Code snippet:

Uncaught (in promise) TypeError: Cannot read property 'abort' of null(…)onCanceled
if (config.cancelToken) {
// Handle cancellation
config.cancelToken.promise.then(function onCanceled(cancel) {
request.abort(); <-- here
reject(cancel);
// Clean up request
request = null;
});
}

[vissermc]

When calling this function twice, I get:

Error: Uncaught (in promise) TypeError: Cannot read property 'abort' of null(…)onCanceled

if (config.cancelToken) {
// Handle cancellation
config.cancelToken.promise.then(function onCanceled(cancel) {
request.abort(); <-- HERE
reject(cancel);
// Clean up request
request = null;
});
}

[cryptic-mystic]

Can confirm. Looks like lines adapters/http.js:191 and adapters/http.js:159 require null checks. For a method that sets the request var to null in several non-edge-cases, I'm surprised the check isn't in there.

[nickuraltsev]

Fixed via 3fcf54f

[cryptic-mystic]

Thanks @nickuraltsev :)

[jadelmir]

I am getting an error while doing get request using axios
TypeError: Cannot read property 'cancelToken' of undefined
what is that and how could deal with it

[palakvasani]

Hello,

I am facing same error as mentioned by jadelmir. Please let me know if anyone has fixed for it. I am using Laravel 5.3 and implements Vue.js to build a chat application.

dispatchRequest.js?91bc:14 Uncaught (in promise) TypeError: Cannot read property 'cancelToken' of undefined at throwIfCancellationRequested (eval at <anonymous> (app.js:192), <anonymous>:14:14) at dispatchRequest (eval at <anonymous> (app.js:192), <anonymous>:26:3)
`
My app.js file looks like this

require('./bootstrap');



Vue.component('chat-messages', require('./components/ChatMessages.vue'));
Vue.component('chat-form', require('./components/ChatForm.vue'));


const app = new Vue({
    el: '#main',

    data: {
        messages: []
    },

    created() {
        this.fetchMessages();
		Echo.private('chat')
		.listen('MessageSent', (e) => {
			this.messages.push({
			  message: e.message.message,
			  user: e.user
			});
		  });
    },
	


    methods: {
        fetchMessages() {
            axios.get('/messages').then(response => {
                this.messages = response.data;
            });
        },

        addMessage(message) {
            this.messages.push(message);

            axios.post('/messages', message).then(response => {
              console.log(response.data);
            });
        }
    }
});

Regards,
Palak