Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header content-encoding isn't automatically convert to lower case. #5890

Closed
sfc-gh-pmotacki opened this issue Sep 11, 2023 · 0 comments
Closed

Header content-encoding isn't automatically convert to lower case. #5890

sfc-gh-pmotacki opened this issue Sep 11, 2023 · 0 comments
Labels
type::beginner A good issue for someone who is new to the project type::feature request Used when requesting a feature

Comments

@sfc-gh-pmotacki
Copy link
Contributor

Describe the bug

Many services respond with header['content-encoding'] in many forms: 'Gzip', 'GZIP', 'GZip'. My example is connected with downloading from storage.googleapis.com. Response header content-encoding has value 'GZIP' and it is a reason why axios don't decompress content. In my opinion header value should be case-insensitive.

To Reproduce

Every request with zipped response with header['content-encoding'] written in non-lowercase letters.

Code snippet

No response

Expected behavior

No response

Axios Version

1.5.0

Adapter Version

http

Browser

chrome

Browser Version

No response

Node.js Version

18

OS

mac os

Additional Library Versions

No response

Additional context/Screenshots

No response
@DavidJDallas DavidJDallas added type::feature request Used when requesting a feature type::beginner A good issue for someone who is new to the project labels Sep 12, 2023
sfc-gh-pmotacki added a commit to sfc-gh-pmotacki/axios that referenced this issue Sep 12, 2023
@sfc-gh-pmotacki
fix(headers): content-encoding header accepts case-insensitive values (…
b9cd394 
…axios#5890)
@sfc-gh-pmotacki sfc-gh-pmotacki mentioned this issue Sep 12, 2023
Merged
DigitalBrainJS pushed a commit that referenced this issue Sep 12, 2023
@sfc-gh-pmotacki
fix(headers): allow content-encoding header to handle case-insensit…
4c89f25 
…ive values (#5890) (#5892)
@GulajavaMinistudio GulajavaMinistudio mentioned this issue Sep 13, 2023
Merged
@github-actions github-actions bot mentioned this issue Sep 26, 2023
Merged
@Omrisnyk Omrisnyk mentioned this issue Oct 28, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 28, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Jan 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type::beginner A good issue for someone who is new to the project type::feature request Used when requesting a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidJDallas @sfc-gh-pmotacki