Decorate resolve and reject to clear timeout in all cases

[pbarbiero]

Changing from manually placed calls to clear the timeout timer, to decorating the resolve/reject promise functions instead.

Fixes #1004, #459
Replaces #487

[rubennorte]

I know it was in the original code but you don't need to set timer = null.

[rubennorte]

I know it isn't necessary but could you also remove the && !timer from the condition below? I think it never applies because the timer is only set inside the if.

[rubennorte]

Could you also remove the && !timer condition from the if? It's only set inside it.

[pbarbiero]

@rubennorte waiting on anything else from me at this point?

[rubennorte]

@pbarbiero travis isn't working for this specific PR and I'm not sure why. Once I figure it out I'll merge this, but the code looks good to me.

[igorsechyn]

This has been an issue for me as well. In my case, I am using axios to make requests from a cli to an external server. If that server is down, i.e. there is no response but ECONNREFUSED error instead, the cli will not exit until the timeout is expired. Would be awesome, if this could be merged.

[datfinesoul]

Any chance this will be released in the near future? I believe it will fix a few timeout issues I've run into, when the request errors.

[pbarbiero]

Politely pinging @nickuraltsev & @rubennorte for a follow up

[TinOo512]

Any news on that? Having the same issue

[pbarbiero]

@emilyemorehouse I hate to bother you, but any chance you can get us moving forward on this one?

[emilyemorehouse]

@pbarbiero no worries!

I've got a work deadline tomorrow morning, but I'll make sure it gets merged this week. I'll also get it included in the next release. 👍

[nickuraltsev]

@pbarbiero Thank you for the fix!