Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unzipping response body only for statuses != 204 #1129

Merged
merged 1 commit into from May 15, 2019

Conversation

@drawski
Copy link
Contributor

drawski commented Oct 13, 2017

Bugfix

When request has Content-Encoding: gzip|deflate|compress header and response has 204 No Content status code the following error is thrown: HttpClientError: unexpected end of file.

This pull request fixes the issue by calling stream = stream.pipe(zip.createUnzip()) for all status codes but 204.

@emilyemorehouse emilyemorehouse force-pushed the axios:master branch 2 times, most recently from 2760755 to 48a7902 Feb 19, 2018
Copy link

OtacilioN left a comment

Can someone please approve this merge request ❤️ I am facing this issue right now

@antonmos

This comment has been minimized.

Copy link

antonmos commented May 13, 2019

Please merge this! this fixes #1658

@OtacilioN

This comment has been minimized.

Copy link

OtacilioN commented May 13, 2019

Hey @antonmos I saw that I received an Email from you, unfortunately, I am not maintainer of this repository and I can`t do this.

@emilyemorehouse emilyemorehouse merged commit fd0c959 into axios:master May 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dpopp07

This comment has been minimized.

Copy link

dpopp07 commented May 15, 2019

@emilyemorehouse thanks for merging this! When can we expect a release with this patch?

This is causing a production bug for me.

irembesik added a commit to irembesik/blockchain that referenced this pull request Oct 5, 2019
this update has an important change 
axios/axios#1129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.