Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unzipping response body only for statuses != 204 #1129

merged 1 commit into from May 15, 2019


Copy link

@drawski drawski commented Oct 13, 2017


When request has Content-Encoding: gzip|deflate|compress header and response has 204 No Content status code the following error is thrown: HttpClientError: unexpected end of file.

This pull request fixes the issue by calling stream = stream.pipe(zip.createUnzip()) for all status codes but 204.

Copy link

@OtacilioN OtacilioN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone please approve this merge request ❤️ I am facing this issue right now

Copy link

Please merge this! this fixes #1658

Copy link

Hey @antonmos I saw that I received an Email from you, unfortunately, I am not maintainer of this repository and I can`t do this.

@emilyemorehouse emilyemorehouse merged commit fd0c959 into axios:master May 15, 2019
Copy link

dpopp07 commented May 15, 2019

@emilyemorehouse thanks for merging this! When can we expect a release with this patch?

This is causing a production bug for me.

irembesik added a commit to irembesik/blockchain that referenced this pull request Oct 5, 2019
this update has an important change 
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants