You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support for the no_proxy environment variable commonly available
with programs supporting the http_proxy/https_proxy environment
* Adds tests to test the no_proxy environment variable.
I have a no_proxy entry in the pattern .a.com and typically this works for excluding all urls that are subdomains of a.com. However this specific implementation does not match the no_proxy against urls that are sub-sub-domains. I found that c.b.a.com is not matched, and continues to proxy. It looks like this implementation was intentional, but seems like a bug from my perspective. Thoughts?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.