Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for no_proxy env variable #1693

Merged
merged 2 commits into from Aug 7, 2018
Merged

Adding support for no_proxy env variable #1693

merged 2 commits into from Aug 7, 2018

Conversation

@chancidickson
Copy link
Contributor

@chancidickson chancidickson commented Jul 24, 2018

This commit adds support for the no_proxy env variable (Issue #434 and on umbrella issue for 1.0.0). It looks like there's an open PR #565, however it has conflicts, adds an unnecessary dependency, and was created in 2016 and hasn't been merged yet. At the company where I work, we are behind a proxy and are having to work around this lack of functionality, and it seems like several people are in a similar situation, so it'd be nice to have this feature. 馃檪

Copy link
Member

@emilyemorehouse emilyemorehouse left a comment

@chancedickson can you add documentation for this to the README?

Otherwise, LGTM and I'll merge it

Loading

* Adds support for the no_proxy environment variable commonly available
  with programs supporting the http_proxy/https_proxy environment
  variables.
* Adds tests to test the no_proxy environment variable.
* Adds documentation to README.md for the supported, conventional
  http_proxy, https_proxy, and no_proxy environment variables.
@chancidickson
Copy link
Contributor Author

@chancidickson chancidickson commented Aug 7, 2018

@emilyemorehouse Added the documentation 馃檪

Loading

@emilyemorehouse emilyemorehouse merged commit 38de252 into axios:master Aug 7, 2018
1 check passed
Loading
@LeeAdcock
Copy link

@LeeAdcock LeeAdcock commented Jun 27, 2019

I have a no_proxy entry in the pattern .a.com and typically this works for excluding all urls that are subdomains of a.com. However this specific implementation does not match the no_proxy against urls that are sub-sub-domains. I found that c.b.a.com is not matched, and continues to proxy. It looks like this implementation was intentional, but seems like a bug from my perspective. Thoughts?

Loading

@OliverCole
Copy link

@OliverCole OliverCole commented Aug 27, 2019

@LeeAdcock
I just hit this bug as well. There is also issue #2160 and PR #1880, which needs merging.

Loading

@Fantaztig Fantaztig mentioned this pull request Oct 29, 2019
@axios axios locked and limited conversation to collaborators May 3, 2020
HellRestaurant pushed a commit to HellRestaurant/cypress-testrail-reporter that referenced this issue Oct 1, 2020
Update axios to 0.20.0 to fix issue where NO_PROXY environment variable is being ignored (fix: axios/axios#1693)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants