New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for no_proxy env variable #1693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chancedickson can you add documentation for this to the README?
Otherwise, LGTM and I'll merge it
* Adds support for the no_proxy environment variable commonly available with programs supporting the http_proxy/https_proxy environment variables. * Adds tests to test the no_proxy environment variable.
* Adds documentation to README.md for the supported, conventional http_proxy, https_proxy, and no_proxy environment variables.
@emilyemorehouse Added the documentation 🙂 |
I have a no_proxy entry in the pattern |
@LeeAdcock |
Update axios to 0.20.0 to fix issue where NO_PROXY environment variable is being ignored (fix: axios/axios#1693)
This commit adds support for the
no_proxy
env variable (Issue #434 and on umbrella issue for 1.0.0). It looks like there's an open PR #565, however it has conflicts, adds an unnecessary dependency, and was created in 2016 and hasn't been merged yet. At the company where I work, we are behind a proxy and are having to work around this lack of functionality, and it seems like several people are in a similar situation, so it'd be nice to have this feature. 🙂