Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Mocha tests. #1993

Merged
merged 1 commit into from Feb 9, 2019
Merged

Fixing Mocha tests. #1993

merged 1 commit into from Feb 9, 2019

Conversation

@GreenTeaCake
Copy link
Contributor

@GreenTeaCake GreenTeaCake commented Feb 9, 2019

TLDR: Fixes #1953

Versions 1.6.0 and 1.6.1 of follow-redirects break Mocha test should support max redirects. The PR updates dependency version to the last compatible one.

@GreenTeaCake
Copy link
Contributor Author

@GreenTeaCake GreenTeaCake commented Feb 9, 2019

@emilyemorehouse Build passes. Please consider merging as a temporary workaround to unblock CI verification.

Loading

@emilyemorehouse
Copy link
Member

@emilyemorehouse emilyemorehouse commented Feb 9, 2019

Thank you!!

Any chance you've seen a changelog or something for follow-redirects? Did I miss it? I was hoping to find a list of possible breaking changes.

Loading

Copy link
Member

@emilyemorehouse emilyemorehouse left a comment

Celebratory taco 🌮🎉

Loading

@emilyemorehouse emilyemorehouse merged commit 2eeb59a into axios:master Feb 9, 2019
1 check passed
Loading
@GreenTeaCake GreenTeaCake deleted the fix-ci-build branch Feb 9, 2019
@GreenTeaCake
Copy link
Contributor Author

@GreenTeaCake GreenTeaCake commented Feb 9, 2019

I'm sorry. I was unable to find the changelog either. :(

Loading

@realityking
Copy link

@realityking realityking commented Jun 5, 2019

@emilyemorehouse These are the changes between 1.5.10 and 1.6.0: follow-redirects/follow-redirects@v1.5.10...v1.6.0

Loading

@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants