Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Mocha tests. #1993

Merged
merged 1 commit into from Feb 9, 2019

Conversation

@grumblerchester
Copy link
Contributor

commented Feb 9, 2019

TLDR: Fixes #1953

Versions 1.6.0 and 1.6.1 of follow-redirects break Mocha test should support max redirects. The PR updates dependency version to the last compatible one.

@grumblerchester

This comment has been minimized.

Copy link
Contributor Author

commented Feb 9, 2019

@emilyemorehouse Build passes. Please consider merging as a temporary workaround to unblock CI verification.

@emilyemorehouse

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

Thank you!!

Any chance you've seen a changelog or something for follow-redirects? Did I miss it? I was hoping to find a list of possible breaking changes.

@emilyemorehouse
Copy link
Member

left a comment

Celebratory taco 🌮🎉

@emilyemorehouse emilyemorehouse merged commit 2eeb59a into axios:master Feb 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@grumblerchester grumblerchester deleted the grumblerchester:fix-ci-build branch Feb 9, 2019

@grumblerchester

This comment has been minimized.

Copy link
Contributor Author

commented Feb 9, 2019

I'm sorry. I was unable to find the changelog either. :(

emilyemorehouse added a commit that referenced this pull request Jun 1, 2019

@realityking

This comment has been minimized.

Copy link

commented Jun 5, 2019

@emilyemorehouse These are the changes between 1.5.10 and 1.6.0: follow-redirects/follow-redirects@v1.5.10...v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.