-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add jsdelivr
and unpkg
support
#2443
Conversation
I see we have axios already in https://cdnjs.com/libraries/axios ? Also we have |
The |
I see https://github.com/jsdelivr/jsdelivr#publishing-packages, so all our versions should be available in jsdelivr as long as we push them to npm |
closing unless I'm missing something, feel free to repoen |
@yasuf those fields are not required but make it easier to discover and use the correct file. jsDelivr supports |
。。。 |
@yasuf you asked the same question before, and I've answered it like @MartinKolarik 's comment, and then you approved this PR. But now you asked the same question... |
sorry @JounQin, I hadn't seen the jsdelivr documentation before, as I see right now, both jsdelivr and unpkg links work, and yes, the current The links for the CDNs work fine right now, the part I'm missing is why we need these explicitly instead of having those services take the files from npm? If so, should it point to the regular Current links: Even the non-minified versions are up |
@yasuf Personally I prefer: https://cdn.jsdelivr.net/npm/axios So that I don't have to know the exact location of Maybe |
@yasuf in case of jsDelivr, that field is used by jsDelivr website/API to indicate which file is the "right one", plus it allows using the shorter link. It should be the minified version (even if you set |
@JounQin can you update it to be the minified file? |
@yasuf Done. |
@yasuf Can we get this PR merged? |
As title