Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix eslint warn #2475

Closed
wants to merge 4 commits into from
Closed

fix eslint warn #2475

wants to merge 4 commits into from

Conversation

Alanscut
Copy link
Collaborator

@Alanscut Alanscut commented Oct 18, 2019 •
edited

fixing eslint warn.

yasuf
yasuf approved these changes Oct 25, 2019
View reviewed changes
Copy link
Collaborator

@yasuf yasuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alanscut Alanscut mentioned this pull request Oct 25, 2019
Merged
@Alanscut
Copy link
Collaborator Author

Alanscut commented Nov 8, 2019

Hi @yasuf , do you have any time to merge it ?

@chinesedfan
Copy link
Collaborator

Closed in favor of #2656.

@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yasuf yasuf yasuf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alanscut @chinesedfan @yasuf