Fixing IE8 support by bringing back onreadystatechange #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| request.onload = function handleLoad() { | ||
| if (!request) { | ||
| request[loadEvent] = function handleLoad() { | ||
| if (!request || (request.readyState !== 4 && !xDomain)) { |
There was a problem hiding this comment.
Maybe we could extract (request.readyState !== 4 && !xDomain) into an explaining variable so it would be easier for people reading the code that understand what this condition is about.
I'm not sure what this does tbh. what does (request.readyState !== 4 && !xDomain) mean?
mzabriskie
added a commit
that referenced
this pull request
Mar 6, 2016
Fixing IE8 support by bringing back onreadystatechange
|
Thank you for your PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing back
onreadystatechangeis a little tricky, since it's also called for requests that errored out.As far as I can see, and after testing it in a few browsers, checking for
request.status === 0is a decent way to know that no real response was received andonerrorwill be called.I've also removed the use of
Array.prototype.indexOfsince that's not available in IE8.