Make default transformResponse parse JSON more properly #2856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar PRs before,
Not sure this is the best solution, because it changes transformers with a new parameter and will break codes depending on silent parsing. So I will not fix tests until we have determined to do.
Now the default
transformResponse
will not parse the string as JSON ifresponseType
istext
. Fixes responseType=text but json is parsed #2791 and several issues in Use the proper transformers for specificdataType
andresponseType
values. #811 (comment).But once tried, invalid JSON string will cause axios rejects. Fixes How to handle error from JSON.parse #61.