Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock travis to not use node v15 #3361

Merged
merged 1 commit into from Oct 23, 2020
Merged

Lock travis to not use node v15 #3361

merged 1 commit into from Oct 23, 2020

Conversation

@jasonsaayman
Copy link
Collaborator

@jasonsaayman jasonsaayman commented Oct 23, 2020

I have made this change due to current builds failing. We should not be testing in node v15 as you can see on this graph https://nodejs.org/en/about/releases/ 10 till 14 should be fine till 2023 and v15 is not LTS so should be excluded for now.

I have made this change due to current builds failing. We should not be testing in node v15 as you can see on this graph https://nodejs.org/en/about/releases/ 10 till 14 should be fine till 2023 and v15 is not LTS so should be excluded for now.
@jasonsaayman jasonsaayman merged commit fbdc150 into master Oct 23, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jasonsaayman jasonsaayman deleted the travis-node-change branch Oct 23, 2020
@simllll
Copy link

@simllll simllll commented Nov 14, 2020

Mhm, I have my concerns with this.
Node 15 is the "current" version of node. We use it in our test enviromnet for example already.

In my opinion axios should run on node 15 as well! What was the failing test?

@jasonsaayman
Copy link
Collaborator Author

@jasonsaayman jasonsaayman commented Nov 19, 2020

@simllll I would be pretty cautious of that since node v15 will only be supported till 2021-06-01 as it is not an LTS version. I don't think that we will be working on non-LTS versions of node as the lifecycle is so short and we cannot invest in non-LTS releases that span less than a year of useful life.

For more info check here

@simllll
Copy link

@simllll simllll commented Nov 19, 2020

Yes, I understand what you mean and I generally agree. The only thing is, that node15 will become node16 which is LTS, it's always that the version before is the "latest" version which becomes the LTS then afterwards. Therefoer supporting node15 right now, will save time later one.

Was there a specific problem to not test against 15?

@jasonsaayman
Copy link
Collaborator Author

@jasonsaayman jasonsaayman commented Nov 19, 2020

Yeah, as far as I can remember a couple of tests were failing. I can re-look into it or you can have a look and put in a pull request to mend issues under node v15 while building.

@simllll
Copy link

@simllll simllll commented Nov 19, 2020

Yeah I was doing that already, and tried to bring the "testing and building pipeline" to the newest state of the art.. right now I'm blocked by karma-runner/karma-sauce-launcher#230.

I am happy to create a PR with v15 support + upgraded build/testing pipeline as soon as I find time to fix the remaining issues with this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.