Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generic AxiosAbortSignal TS interface to avoid importing AbortController polyfill #4229

Merged
merged 14 commits into from May 4, 2022

Conversation

DigitalBrainJS
Copy link
Contributor

@DigitalBrainJS DigitalBrainJS commented Oct 29, 2021

Fixes #4124 by adding a generic AbortSignal interface.

@DigitalBrainJS
Copy link
Contributor Author

DigitalBrainJS commented Nov 30, 2021

@jasonsaayman can this be reviewed and merged to avoid subsequent issues?

@vishalailani
Copy link

vishalailani commented Dec 2, 2021

@DigitalBrainJS / @jasonsaayman, i am also facing the same issue. is it merged ? if not please merge this as all checks have already passed.

@j4ys0n
Copy link

j4ys0n commented Dec 2, 2021

+1 can this be merged please? my build is failing because of the issue this fixes.

thank you!

@juditvarro
Copy link

juditvarro commented Dec 6, 2021

+1
Could you please give an estimation @DigitalBrainJS / @jasonsaayman when can we expect that this will be merged? Thank you!

@DigitalBrainJS
Copy link
Contributor Author

DigitalBrainJS commented Dec 7, 2021

@juditvarro Unfortunately, I can't provide an estimation as I'm not a member of the Axios team. The project is maintained by @jasonsaayman and @chinesedfan, so everything is up to them.

@corrjo
Copy link

corrjo commented Dec 9, 2021

I'll be the next to nag here. @jasonsaayman @chinesedfan 🙏

@swain
Copy link

swain commented Dec 27, 2021

+1 @jasonsaayman @chinesedfan

@nyalsadiq
Copy link

nyalsadiq commented Jan 31, 2022

Is there anything we can do to help get this merged soon? @jasonsaayman @chinesedfan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of AbortController ist breaking for setup without DOM Library
8 participants