Split progress event handlers into upload and download. #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // as well as 'GET' downloads | ||
| progress: function (progressEvent) { | ||
| // `progressUpload` allows handling of progress events for uploads | ||
| progressUpload: function (progressEvent) { |
There was a problem hiding this comment.
I would suggest to rename progressUpload and progressDownload to onUploadProgress and onDownloadProgress respectively.
… events before attaching. Updated tests to use Spies.
|
@nickuraltsev the Jasmine AJAX fakeXHR hasn't implemented upload events. So i can't do any tests on that yet. I'm gonna create an issue/PR over there so we can test this properly, not sure if you wanna wait for that before merging this. In the meantime i've switched the tests to use spies which is much nicer. |
|
@diesal11 Thank you! Could you please also rename the config options in README.md? Everything else looks good to me. |
|
@diesal11 Merged. Thank you for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits progress config into two options,
progressDownloadandprogressUpload. No longer limits these toGET/POST/PUTrequests.Previously there were no tests for progress handling...so i've added some. But testing is difficult as the Jasmine-AJAX plugin doesn't handle
xhr.upload.addEventListenercorrectly. Im also not overly familiar with Jasmine and it's tools so if you have any ideas on how i could improve the tests please let me know :)At some point in future i'll do a PR to allow progress events in the Node world.