Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AxiosError.config optional in the type definition #4665

Merged
merged 2 commits into from May 3, 2022

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented May 3, 2022

In the source, the JSdoc for config is the following:

 * @param {Object} [config] The config.

It is assigned as such:

config && (this.config = config);

The type in index.d.ts is thus incorrect and needs to be optional.

It is optional in the constructor, and not always defined.
tusbar added a commit to tusbar/axios-logger that referenced this pull request May 3, 2022
Sometimes, axios throws an error without `error.config`, this makes sure
we don’t destructure an undefined property.

Related: axios/axios#4665
Fix hg-pyun#94
tusbar added a commit to tusbar/axios-logger that referenced this pull request May 3, 2022
Sometimes, axios throws an error without `error.config`, this makes sure
we don’t destructure an undefined property.

Related: axios/axios#4665
Fix hg-pyun#94
@jasonsaayman jasonsaayman merged commit 205bd0f into axios:master May 3, 2022
3 checks passed
@tusbar tusbar deleted the fix-axios-error-config-type branch May 4, 2022
hg-pyun added a commit to hg-pyun/axios-logger that referenced this pull request May 7, 2022
Sometimes, axios throws an error without `error.config`, this makes sure
we don’t destructure an undefined property.

Related: axios/axios#4665
Fix #94

Co-authored-by: Haegul Pyun <phg2491@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants