fix: modify log while request is aborted #4917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the previous log 'maxContentLength size of {maxContentLength} exceeded' does not represent an acutual error, I just modified the sentence.
|
Please can you check the CI is failing |
….com:mori5321/axios into fix/modify_log_while_response_stream_aborted
|
@jasonsaayman Sorry, I didn't notice that mention. |
|
I rewrite the test. |
|
Do not understand the idea behind this fix? You mention "This is not an error", but you keep calling AxiosError. What is this? |
anuraag-smartly
approved these changes
Jul 12, 2023
|
@mori5321 Are you able to bring this branch up to date and point this PR at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change a log sentence of "aborted response handling".
fix: #4806
Why
The previous log says 'maxContentLength size of {maxContentLength} exceeded',
but it does not represent an actual error, because it is caused by aborted response stream.